frontend: Work On The Error Page This commit is for mo… #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should add a screenshot in the PR description of the page added. |
Closed
|
@asmit27rai Please make the commit heading shorter and leave a line before writing the body. That way, it renders well. |
… pages that show if unknown route is accessed and then it give link to homepage by using link from react-router-dom and also remove display flex option from body \n Fixes: shivansh-bhatnagar18#21
This commit is for modified error pages that show if unknown route is accessed and then it give link to homepage by using link from react-router-dom and also remove display flex option from body Fixes: shivansh-bhatnagar18#21
|
Thank you @asmit27rai for your Pull Request. Every Pull request matters but we have found out a better Error page for the same. For now I am closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design Error Page
Fixes: #21
Description
I used tailwind css to make this error page which render when known route get accessed and has go to homepage option created by link of react-router-dom with some modification using tailwindcss.
How to Test
Just Run the "npm run dev" command in frontend and on app page try to access page of unknown route.
Checklist
Screenshot